search

roman-corgi / corgidrp

Data Reduction Pipeline for the Roman Coronagraph Instrument
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

no calibration numbers in DetectorParams #125

Closed kjl0025 closed 4 months ago

kjl0025 commented 5 months ago

All calibration numbers should come from calibration class instance input to a function rather than from detectorParams (e.g., k gain), and there should be history records for which calibration files were used for a given step function that directly uses the calibration file.

maxwellmb commented 5 months ago

I think this should be written out more in the README than in an issue. It seems like a more general philosophy than an issue, so its unclear how we'd ever close the issue. I think adding instructions for developers along these lines would be a good idea, perhaps with an example for the DetectorParams file and one counter example (K-gain as you suggested is fine).

semaphoreP commented 4 months ago

Yeah, this isn't something that is actionable right now, other than removing K-gain from DetectorParams. If you agree, let's close them.

maxwellmb commented 4 months ago

@kjl0025 can we close this or is there a specific thing you think still needs to be applied?

kjl0025 commented 4 months ago

I agree, we can close this.