search

roman-corgi / corgidrp

Data Reduction Pipeline for the Roman Coronagraph Instrument
4 stars 2 forks source link

no calibration numbers in DetectorParams #125

Open kjl0025 opened 3 days ago

kjl0025 commented 3 days ago

All calibration numbers should come from calibration class instance input to a function rather than from detectorParams (e.g., k gain), and there should be history records for which calibration files were used for a given step function that directly uses the calibration file.

maxwellmb commented 3 days ago

I think this should be written out more in the README than in an issue. It seems like a more general philosophy than an issue, so its unclear how we'd ever close the issue. I think adding instructions for developers along these lines would be a good idea, perhaps with an example for the DetectorParams file and one counter example (K-gain as you suggested is fine).