search

roman-corgi / corgidrp

Data Reduction Pipeline for the Roman Coronagraph Instrument
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

move specification of good columns used for bias estimation from detector.py to DetectorParams? #127

Closed kjl0025 closed 4 months ago

kjl0025 commented 4 months ago

Perhaps it makes more sense to house the specification of the reliable columns in DetectorParams for flexibility instead of hard-coded in detector.py (if not all the geometry info in detector.py)?

semaphoreP commented 4 months ago

Max and I decided for now that we are keeping them in detector.py for now, as we aren't expecting them to change ("constants"). Please re-open if you think there are any issues with this.