search

roman-corgi / corgidrp

Data Reduction Pipeline for the Roman Coronagraph Instrument
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

.corgidrp directory for config made in __init__.py must be deleted in order for an updated directory to be made #128

Closed kjl0025 closed 3 months ago

kjl0025 commented 4 months ago

Perhaps we should add to the README that a user should delete .corgidrp if a new config is desired upon installation. Or we could have something in init.py to see if necessary keys are present and if not to remake the config?

semaphoreP commented 4 months ago

Yes, it is a bit inevitable that the installation will be broken as we are still in very early stages of development. I agree that we should add something about deleting .corgidrp and re-running the install.

Do you have the error message that pops up when this occurs, so we can advise on the README when to do the reinstall?

kjl0025 commented 4 months ago

Sorry I'm just getting to this. I deleted my .corgidrp to get init.py to install a fresh config, so I don't recall the specific error. But the error was caused by the addition of a key to the config, and init.py didn't make a new config b/c it currently only does that if one doesn't already exist. I could fix this in another PR soon if you'd like.

semaphoreP commented 4 months ago

Sure, although I'd put this at low priority until we start releasing the code for public consumption.

semaphoreP commented 3 months ago

Remaining task: add to README that deleting the .corgidrp directory is a possible troubleshooting solution