Can nonlin_tableTVAC.txt in test_data be replaced by nonlin_sample.csv?

roman-corgi / corgidrp

Data Reduction Pipeline for the Roman Coronagraph Instrument

BSD 3-Clause "New" or "Revised" License

5 stars 4 forks source link

Can nonlin_tableTVAC.txt in test_data be replaced by nonlin_sample.csv? #138

Closed hsergi closed 2 months ago

hsergi commented 4 months ago

nonlin_tableTVAC.txt might be able to replace the existing nonlin_sample.csv and associated fits file. This is a nice-to-have not a full requirement in order to keep the number of test_data files as small as possible: https://github.com/roman-corgi/corgidrp/pull/116#pullrequestreview-2163979641:

kjl0025 commented 4 months ago

I just wanted to note that this .txt file is not the latest and greatest nonlin calibration file from TVAC. Nonetheless, I am fine with what this issue requests. The nonlin_sample.csv was a vestige for tests from other ported code that used it, but nothing in the DRP currently uses it.

semaphoreP commented 2 months ago

Fixed in PR #179