search

roman-corgi / corgidrp

Data Reduction Pipeline for the Roman Coronagraph Instrument
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

L2b header cross-checks #142

Open mygouf opened 4 months ago

mygouf commented 4 months ago

Is your feature request related to a problem? Please describe. No

Describe the solution you'd like

Task 1: Check consistency between provided L2b frames from II&T data and the II&T headers keywords page.

Task 2: Check consistency between EXCAM image headers (working page) on the wiki, and II&T headers keywords.

The page EXCAM image headers (working page) should be edited to add any keywords currently missing. The II&T headers keywords page is the reference and what is currently implemented for the L1 data and what was implemented for the II&T L2a and L2b data.

Task 3: Check that the DRP implementation is consistent with the II&T headers keywords page

Additional context Add any other context or screenshots about the feature request here.

semaphoreP commented 3 months ago

I'd add that check that the files output by the l1_to_l2b e2e test does have all the necessary headers we expect, and add this to the existing test.

juliamilton commented 2 months ago

Tasks 1 and 2 are complete. The historical list of L2b headers has been reviewed and updated to match the actual headers used in II&T. This information is now available in the EXCAM image headers (working page).

It seems that the page referenced for Task 3 (II&T headers keywords) no longer exists. I plan to create a new page under "Data format and volume" today, which will show the keywords included for each header in the upcoming release of L2b DRP products.

@maxwellmb @semaphoreP, could you clarify what is meant by the "list of all necessary headers" expected for inclusion in this release? Additionally, will the constants.py file mentioned in the linked issue be used? Otherwise, I’ll verify the outputs from the L2b end-to-end test to produde the list of headers currently included and flag any missing II&T keywords.

maxwellmb commented 2 months ago

I don't think we've yet implemented a constants.py. We were hoping to have a list of the required header keywords for each level saved somewhere in the pipeline, such that it could be checked when updating the data level and saving. If not present I think we'd want to create them and populate them with dummy values for archiving purposes.

Given the current time-frame I think this will have to be bumped to the next release.