search

roman-corgi / corgidrp

Data Reduction Pipeline for the Roman Coronagraph Instrument
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

creation of onsky flatfield #151

Closed ramya-anche closed 3 months ago

ramya-anche commented 4 months ago

Creates flat fields using HST images of Neptune and Uranus.

  1. 36 Raster scanned images are generated using the median combined HST image frames
  2. The images are cropped and combined to create a matched filter in groups of 3.
  3. The raster images are divided by the matched filter and combined to create a flatfield.
semaphoreP commented 4 months ago

Hi Ramya, can you fix the conflicts with the main branch, so that the tests can run? Let me know if you need any help with conflict fixing!

maxwellmb commented 3 months ago

Note: I had to add the appropriate git-lfs hooks into the CI settings, as previously it was not doing a git-lfs pull to get the new fits files. It was causing the build to fail here, and not before, since the test files introduced here are the first ones that actually triggered the git-lfs system.

maxwellmb commented 3 months ago

Looking good now! I have some minor coding comments, and 1 bigger conceptual thing we should think about: we should think about what parameters in the flat field generation should be tunable and exposed to the user as optional keywords in the create_onsky_flatfield function. Perhaps @rzellem has some thoughts on this?

As a general philosophy (not having looked at the code): Given that Flat Fielding is classified as Software Class C, I'd like to maximize the flexibility by putting as much as possible as function keyword arguments.