Implemented end-to-end test for the trap calibration. The outputs exactly match those of the TVAC outputs on the same dataset. The simulated data (since we didn't have complete TVAC data for this) was made more realistic as well for the e2e test.
It turns out that for full-size frames, some of the "tricky" simulated traps are not found by the code. I have added an optional input to the function to allow the user to specify the bin size for the illumination_correction() function. Setting this to 10 allows the e2e test to find all the traps that were simulated, but this option was not available to the II&T code, so this optional input is not used in the e2e test. I will document all these details on the Confluence page.
Type of change
New feature (non-breaking change which adds functionality)
Reference any relevant issues (don't forget the #)
148
Checklist before requesting a review
[X ] I have linted my code
[X ] I have verified that all unit tests pass in a clean environment and added new unit tests, as needed
[X ] I have verified that all docstrings are properly formatted and added new documentation, as needed
Describe your changes
Implemented end-to-end test for the trap calibration. The outputs exactly match those of the TVAC outputs on the same dataset. The simulated data (since we didn't have complete TVAC data for this) was made more realistic as well for the e2e test.
It turns out that for full-size frames, some of the "tricky" simulated traps are not found by the code. I have added an optional input to the function to allow the user to specify the bin size for the
illumination_correction()
function. Setting this to 10 allows the e2e test to find all the traps that were simulated, but this option was not available to the II&T code, so this optional input is not used in the e2e test. I will document all these details on the Confluence page.Type of change
Reference any relevant issues (don't forget the #)
148
Checklist before requesting a review