roman-corgi / corgidrp

Data Reduction Pipeline for the Roman Coronagraph Instrument
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

Cti e2e #198

Closed kjl0025 closed 2 months ago

kjl0025 commented 2 months ago

Describe your changes

Implemented end-to-end test for the trap calibration. The outputs exactly match those of the TVAC outputs on the same dataset. The simulated data (since we didn't have complete TVAC data for this) was made more realistic as well for the e2e test.

It turns out that for full-size frames, some of the "tricky" simulated traps are not found by the code. I have added an optional input to the function to allow the user to specify the bin size for the illumination_correction() function. Setting this to 10 allows the e2e test to find all the traps that were simulated, but this option was not available to the II&T code, so this optional input is not used in the e2e test. I will document all these details on the Confluence page.

Type of change

Reference any relevant issues (don't forget the #)

148

Checklist before requesting a review

kjl0025 commented 2 months ago

Just pushed that change you wanted (relative error of < 1e-4). Should all be good to go.