Get rid of hard-coded key combinations at let users use the key or key combination of their choice for every single action

[GoogleCodeExporter]

e.g.:
currently users can set "precise" key,  "team bar toggle" key and "move left" 
key

this will automatically also set the "invisible" actions
"hog tag toggle" to precise+teambartoggle,
"turn hedgehog left" to precise+moveleft,
etc.

these actions (turning hog, toggling tags, shooting from saucer, etc.) should 
just have those "precise"(actually: shift) key-combinations as default and 
instead let the user bind custom keys or key combinations to each of those 
actions.

Original issue reported on code.google.com by sheepyluva on 9 Jan 2014 at 11:55

[GoogleCodeExporter]

Hm, this would impact a lot of places, is kind of a pain to do, and I'm not 
sure offers much in the way of any utility.

So. Let's take a look at this...

Precise = modifier key for actions.

With this description and some decent documentation, the current uses make more 
sense, and are consistent.

Delete - general purpose, label toggling.  Without modifier, toggles team 
health/name/playername.  With modifier, toggles individual hogs.

Left/Right - general purpose, movement.  Without modifier, moves in a 
direction, turning if necessary.  With modifier, turns only.

Up/Down - general purpose, aiming.  This one is a bit more complex, so 
documenting takes a few cases.
* Typical case, adjust aim in increments of one hedgewars degree unit per tick
* Additional case, adjust aim in increments of 2 hedgewars degree units per 
tick for weapons that need fast response while moving around like portal and 
rope
* With modifier to typical case, adjust aim in increments of one hedgewars 
degree every 5 ticks
* Additional case with modifier, allows aiming of saucer.

I think decoupling these would poorly serve the player since there is an 
organisation to it right now, as well as being a pain for us to keep track of.

I would recommend instead better documentation of what the modifier does, and 
in what cases.

I propose turning this into a documentation enhancement bug for the frontend.

I also strongly disagree with the proposal to make the precise behaviour 
"default"  - typically the modifier action is the less commonly used case, so 
making it default would poorly serve the player.

Original comment by kyberneticist@gmail.com on 9 Jan 2014 at 3:29

• Removed labels: Component-QtFrontend

[GoogleCodeExporter]

Adding back component removed by mistake.
Also, I misunderstood the default part.
He means for every one of these, where precise modifies something, add a new 
row in binds for that action, with the default being the current combo, like 
left shift + up or left shift + down
So...
I guess that would look like (in addition to current binds):
left shift + up     - aim up precisely
left shift + down   - aim down precisely
left shift          - adjust aim while using saucer (or would this be extra 
text on up and down? But surely that violates his goal of keeping separate 
behaviour, since those 2 binds would now have an extra function)
left shift + left   - turn in place to the left
left shift + right  - turn in place to the right
left shift + 1      - set bounciness to slight
left shift + 2      - set bounciness to low
left shift + 3      - set bounciness to normal
left shift + 4      - set bounciness to high
left shift + 5      - set bounciness to extreme
left shift + delete - toggle hog labels

Aaand if we ever came up with any other modifiers, we'd add to the list.  I 
dunno, this seems a bit more clunky.  I still like the documentation option.  
Also, given how engine currently checks the modifier, we'd prob want to rethink 
engine flagging.  Use some intermediary toggle table mapped by the new combos.

Original comment by kyberneticist@gmail.com on 9 Jan 2014 at 11:13

• Added labels: Component-QtFrontendComponent-Engine
• Removed labels: Component-Engine

[GoogleCodeExporter]

trying again. google code sucks at degrading gracefully compared to, oh, 
bugzilla, but at least it does a better job than github.

Original comment by kyberneticist@gmail.com on 9 Jan 2014 at 11:17