roman-murashov / hedgewars

Automatically exported from code.google.com/p/hedgewars
GNU General Public License v2.0
0 stars 0 forks source link

Hedgewars treats spaces in campaign folder name as underscore #845

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Download the Shoppa Challenge campaign by sphrinx
2. Try so select a mission
3. Click start

What is the expected output? What do you see instead?
First I expect that I am able to select a mission and second I expect that I 
can start it.

Actually I can’t even select a mission. When I click on the start button, the 
mission does not start, unsurprisingly.

As soon as I select the campaign in question, this message appears in the 
console:

[PHYSFS] Failed to open /Missions/Campaign/Shoppa_Challenge/campaign.ini, 
reason: no such path

I get the same message a few times again when I click on the start button.

Note that the actual campaign folder is “Shoppa Challenge”, not 
“Shoppa_Challenge”! Renaming the folder to “Shoppa_Challenge” is a 
possible workaround.

The user claimed that this campaign worked in 0.9.19 so far.

What version of the product are you using? On what operating system?
I use 0.9.20, where said campaign did not work for me unless I applied the 
workaround.

Please provide any additional information below.

You can download the campaign in question from here:
http://www.hedgewars.org/node/5427

Original issue reported on code.google.com by almikes@aol.com on 2 Dec 2014 at 9:25

GoogleCodeExporter commented 8 years ago
Hi, the change that broke this is rc9978ada9a3d.

After checking my irc logs, the motivation behind this change was the total 
annoyance (of the developers) when dealing with white-spaces inside the code.

We considered the maintenance of the old saved progress 
(https://code.google.com/p/hedgewars/issues/detail?id=722) but I personally 
haven't considered the case that you describe.

I guess I can provide a patch that will take account of campaign names using 
white-spaces instead of underscores, but I think that the right solution is 
content outside the hedgewars official release get labeled properly and users 
download the appropriate content for their hedgewars version. Other than that, 
it should be up to the extra content author/maintainer to make the content 
available for the versions that she wants to support.

So, I will wait for some more thoughts/feedback on this to see what course is 
the most appropriate.

Original comment by pntana...@gmail.com on 3 Dec 2014 at 12:00