search

roman / golden-ratio.el

Automatic resizing of Emacs windows to the golden ratio
MIT License
589 stars 38 forks source link

Simplify `golden-ratio-mode' #48

Closed abo-abo closed 9 years ago

thierryvolpiatto commented 9 years ago

Thanks, but now golden-ratio is not happening when splitting windows. Also, golden-ratio-exclude-modes have no more effects.

abo-abo commented 9 years ago

Thanks, but now golden-ratio is not happening when splitting windows.

No problem, just needs one more advice.

Also, golden-ratio-exclude-modes have no more effects.

Fixed up, that logic was lost in the merge conflict.

thierryvolpiatto commented 9 years ago

Ok looks good now, thanks.

thierryvolpiatto commented 9 years ago

Oleh Krehel notifications@github.com writes:

Thanks, but now golden-ratio is not happening when splitting windows.

No problem, just needs one more advice.

Also, golden-ratio-exclude-modes have no more effects.

Fixed up, that logic was lost in the merge conflict.

Now scrolling in Gnus is broken...

Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997

abo-abo commented 9 years ago

Now scrolling in Gnus is broken...

It works fine for me.

thierryvolpiatto commented 9 years ago

Oleh Krehel notifications@github.com writes:

Now scrolling in Gnus is broken...

It works fine for me.

I mean gnus-summary-scroll-up (press RET repetitively from summary buffer).

Maybe it is working in emacs-25 due to a difference in select-window, but it is broken in emacs-24.4/5.

Disabling golden-ratio-mode let it working, switching to version 1.0 of golden ratio fix the problem too.

Please try to fix, otherwise I will look into this ASAP (not the time now).

Thanks.

Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997

abo-abo commented 9 years ago

I mean gnus-summary-scroll-up (press RET repetitively from summary buffer). Maybe it is working in emacs-25 due to a difference in select-window, but it is broken in emacs-24.4/5.

Its scrolls fine in 24.5.2. Although it's weird to have golden-ratio on at all for gnus, since it makes the summary (which I like to keep small) much larger than the article.

thierryvolpiatto commented 9 years ago

Its scrolls fine in 24.5.2.

No it doesn't. I have opened an issue #49 .