roman / golden-ratio.el

Automatic resizing of Emacs windows to the golden ratio
MIT License
589 stars 38 forks source link

Vertical spilt gives reverse golden ratio #55

Closed dakrone closed 9 years ago

dakrone commented 9 years ago

When I use a horizontal split, everything is peachy (dark modeline is the active window):

screenshot from 2015-07-20 07-34-16 screenshot from 2015-07-20 07-34-20

But when I split vertically, I get "opposite" golden ratio, where the active window is the smaller one:

screenshot from 2015-07-20 07-34-36 screenshot from 2015-07-20 07-34-38

thierryvolpiatto commented 9 years ago

Lee Hinman notifications@github.com writes:

When I use a horizontal split, everything is peachy (dark modeline is the active window):

screensh screensh

But when I split vertically, I get "opposite" golden ratio, where the active window is the smaller one:

screensh screensh

This is not reproductible here, it seems some other mode is confusing golden-ratio.

Try to start for emacs -Q, and then load only golden-ratio and enable its mode, it should work fine.

Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997

dakrone commented 9 years ago

Okay, I'll try to reproduce and see what's interfering with it. Thanks!

indigoviolet commented 7 years ago

btw, I can repro this on a widescreen monitor, with (setq golden-ratio-auto-scale t) -- if I turn that off it goes away

FrauH0lle commented 5 years ago

I encountered the same issue and the reason seems to be evil mode. A possible solution can be found here. One can add something like

;; golden-ratio-extra-commands
(dolist (f '(evil-avy-goto-word-or-subword-1
             evil-avy-goto-line
             evil-window-delete
             evil-window-split
             evil-window-vsplit
             evil-window-left
             evil-window-right
             evil-window-up
             evil-window-down
             evil-window-bottom-right
             evil-window-top-left
             evil-window-mru
             evil-window-next
             evil-window-prev
             evil-window-new
             evil-window-vnew
             evil-window-rotate-upwards
             evil-window-rotate-downwards
             evil-window-move-very-top
             evil-window-move-far-left
             evil-window-move-far-right
             evil-window-move-very-bottom))
  (add-to-list 'golden-ratio-extra-commands f))

to the golden-ratio config.