search

roman / golden-ratio.el

Automatic resizing of Emacs windows to the golden ratio
MIT License
589 stars 38 forks source link

Allow buffer exclusion with regular expressions #58

Closed punassuming closed 9 years ago

punassuming commented 9 years ago

Added a feature to exclude buffer names based on regexp list. To exclude all helm buffers now, I use

(add-to-list 'golden-ratio-exclude-buffer-regexp "*[hH]elm.*")
thierryvolpiatto commented 9 years ago

I installed the changes using loop. Thanks.

syl20bnr commented 8 years ago

@thierryvolpiatto just a note on this PR. It is not very nice from you to not merge this PR and instead merge an almost identical one from you :-(

Good etiquette is to merge this one since it works and then refactor it, you could have even cherry-picked it and made the modification locally in a separate commit before pushing the two commits.

thierryvolpiatto commented 8 years ago

Sylvain Benner notifications@github.com writes:

@thierryvolpiatto just a note on this PR. It is not very nice from you to not merge this PR and instead merge an almost identical one from you :-(

Good etiquette is to merge this one since it works and then refactore it, you could have even cherry-picked it and made the modification locally before pushing in a separate commit.

Probably I am not a perfect man like you who know everything.

Thierry

https://emacs-helm.github.io/helm/ Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997

thierryvolpiatto commented 8 years ago

@ralesi , very sorry if it offended you I did not merge your PR,but it was not working and I have only few time to review PR and fix.