search

roman / golden-ratio.el

Automatic resizing of Emacs windows to the golden ratio
MIT License
589 stars 38 forks source link

Allow golden-ratio.el to work with ace-window #59

Closed mattfidler closed 8 years ago

mattfidler commented 8 years ago

This adds a simple advice so that ace-window works with ace-window

syl20bnr commented 8 years ago

Thank you for the PR. You don't need to advice ace-window, please use golden-ratio-extra-commands variable. Example: https://github.com/syl20bnr/spacemacs/blob/82c905559a0bd6186d4195b2b7a23343a4a73963/spacemacs/packages.el#L1245-L1295

thierryvolpiatto commented 8 years ago

Indeed it is not the place to advice ace-window.

mattfidler commented 8 years ago

Thanks.