search

roman / golden-ratio.el

Automatic resizing of Emacs windows to the golden ratio
MIT License
589 stars 38 forks source link

Add minor modes to exclusion list? #63

Open mattfidler opened 8 years ago

mattfidler commented 8 years ago

Currently, golden-ratio excludes based on major modes. However, excluding based on minor-modes may also be useful. For example minimap-mode shouldn't allow golden-ratio to modify. Of course this can be accomplished with golden-ratio-inhibit-functions, or even golden-ratio-exclude-buffer-names. However, I think that it may also be useful to add a customizable variable for minor-modes.

mattfidler commented 8 years ago

I actually can't figure out what to toggle to make the minimap work correctly.

I have tried

(defun ergoemacs-golden-ratio-exclude-minimap-p ()
      (memq this-command '(minimap-toggle)))
    (setq golden-ratio-inhibit-functions '(ergoemacs-golden-ratio-exclude-minimap-p))
(add-to-list 'golden-ratio-exclude-buffer-regexp "^\\*MINIMAP\\*")

But it doesn't quite work correctly.

wictory commented 4 years ago

It seems that simply inhibiting minimap-mode does not solve every issue between golden-ratio-mode and minimap-mode.