Golden-ratio-mode kills dired-sidebar

lshoravi commented 5 years ago

Enabling golden-ratio-mode and using dired-sidebar always ends up in the dired-sidebar window not being valid. Attempting to switch to the sidebar window with C-x o doesn't work, and clicking in the sidebar results in this:

Debugger entered--Lisp error: (wrong-type-argument window-valid-p #<window 80>)
  window-minibuffer-p(#<window 80>)
  mouse-minibuffer-check((double-drag-mouse-1 (#<window 80> 1363 (433 . 788) 5956871 nil 1363 (25 . 21) nil (297 . 11) (17 . 37)) (#<window 86> 666 (314 . 400) 5957359 nil 666 (18 . 10) nil (110 . 30) (17 . 37))))
  mouse-set-region((double-drag-mouse-1 (#<window 80> 1363 (433 . 788) 5956871 nil 1363 (25 . 21) nil (297 . 11) (17 . 37)) (#<window 86> 666 (314 . 400) 5957359 nil 666 (18 . 10) nil (110 . 30) (17 . 37))))
  funcall-interactively(mouse-set-region (double-drag-mouse-1 (#<window 80> 1363 (433 . 788) 5956871 nil 1363 (25 . 21) nil (297 . 11) (17 . 37)) (#<window 86> 666 (314 . 400) 5957359 nil 666 (18 . 10) nil (110 . 30) (17 . 37))))
  call-interactively(mouse-set-region nil nil)
  command-execute(mouse-set-region)

4goodapp commented 4 years ago

Am having the same issue.

wictory commented 4 years ago

I got golden-ratio-mode to play along with dired-sidebar-mode by adding the following line to my config:

(add-to-list 'golden-ratio-exclude-modes 'dired-sidebar-mode)

Does this also work for you?

lshoravi commented 4 years ago

Indeed, it does. Thanks!

roman / golden-ratio.el

Golden-ratio-mode kills dired-sidebar #80