search

roman / golden-ratio.el

Automatic resizing of Emacs windows to the golden ratio
MIT License
589 stars 38 forks source link

Fix for the window margins #85

Closed vmfhrmfoaj closed 11 months ago

vmfhrmfoaj commented 3 years ago

Some buffer(e.g., magit-log: ...) has the margin, and the return value of window-width is not included the margin. So, sometime, golden-ratio--resize-window compute the width wrongly.

To fix the problem I used window-margins function. It was included at ver 21.1. I think safe to use window-margins function.

resolve #84

roman commented 11 months ago

Hello @vmfhrmfoaj,

I understand it has been a long time since you submitted this PR. Sadly, some changes to the main branch conflict with these changes.

If you want to send a newer change for this PR, I'll accept it immediately.

Cheers.

vmfhrmfoaj commented 11 months ago

Hello @roman

I fixed a conflict.

Thank you.