Switch from 'cl' to 'cl-lib' to supress warnings.

roman / golden-ratio.el

Automatic resizing of Emacs windows to the golden ratio

MIT License

589 stars 38 forks source link

Switch from 'cl' to 'cl-lib' to supress warnings. #91

Closed pataquets closed 11 months ago

pataquets commented 1 year ago

Supress several Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead. warning messages. Fixes #87.

Require cl-lib instead of cl.
Replaced all (loop) calls by their corresponding (cl-loop) counterparts.
Ditto for (first) and (second) calls.

@roman: let me know if I'm missing some other functions and I'll be happy to update the PR.

pataquets commented 11 months ago

@roman: ping. Let me know if there is something else needed to be done here. This would close #87, and is also a superset of #88. /cc: @shouya, who has merged this, in case he/she has any feedback.

shouya commented 11 months ago

I've been using my own fork with this one merged without change and it's been working perfectly. I would be glad to see the owner merge this (and other PRs) though.

roman commented 11 months ago

Hey @pataquets, apologies for the long delay... life tends to get in the way.

Can you please rebase your branch with master? I'll merge it once you push a version that doesn't conflict.

pataquets commented 11 months ago

@roman No worries, life is always in the way :smile: Rebased and force-pushed branch.