search

roman01la / cljs-rum-realworld-example-app

ClojureScript + Rum codebase containing real world examples
53 stars 9 forks source link

Add user authorization #7

Closed foopang closed 7 years ago

foopang commented 7 years ago

Hi, I'm new to ClojureScript, so I think this is a great project for me to practice ClojureScript. And this is my first attempt in contributing to this project. Hope to get some feedback.

roman01la commented 7 years ago

Hi. Thanks for the PR, unfortunately I'm not able to review it because it's pretty big change in a single commit. It's quite hard to review a large scope of work at once. It would be much easier if you could break down this PR into a series of smaller commits each explaining the change.