search

roman01la / html-to-react-components

Converts HTML pages into React components
https://roman01la.github.io/html-to-react-components/
MIT License
2.13k stars 136 forks source link

Bug: Quotation marks not being converted correctly? Renders as unknown character. #28

Closed mandajoan closed 6 years ago

mandajoan commented 6 years ago

Yesterday I ran code through the package and it was fine, but today it failed to process any of the quotation marks in my html document when converting to react component. I 'm not 100% sure that something on my end didn't set it off, though I am at a loss to what that could have been. Nothing has changed other than some of the html content in the file and the file name, which was updated to reflect the version I am working on.

This happened with all single and double quotation marks.

image

Update:

Also failed to convert:

Ellipses--

image

Dash--

image

should be:

image

roman01la commented 6 years ago

Can't really help here, sorry. Could you paste that document here so I can test it on my side?

mandajoan commented 6 years ago

I am sorry, I can't post the document because of NDA. But I have run the package twice since I posted the issue and it is still not translating the punctuation correctly.

mandajoan commented 6 years ago

I am going to close this as I am not sure if its even an issue with the package. Thank you!