Update closure to latest version: 20180101

roman01la / webpack-closure-compiler

[DEPRECATED] Google Closure Compiler plugin for Webpack

MIT License

464 stars 25 forks source link

Update closure to latest version: 20180101 #41

Closed bacher09 closed 6 years ago

bacher09 commented 6 years ago

I updated closure compiler to latest version. Also, seems package-lock.json should be updated. It still have old version: 2.1.4.

bacher09 commented 6 years ago

I rolled back change for google-closure-compiler-js since it crashed tests on travis.

roman01la commented 6 years ago

Thanks. Both js and jvm compiler should be of the same version. Need to investigate why js tests are broken.

bacher09 commented 6 years ago

I have found what caused this issue. Seems js version of closure-compiler have changed input format for externs option. Tomorrow I will update this PR with fix that will be backward compatible.

roman01la commented 6 years ago

@bacher09 Is it ready to merge?

bacher09 commented 6 years ago

Yes, I updated PR.

roman01la commented 6 years ago

Great, thanks!