Enable proxy_arp per interface

romana / core

Romana core components - Micro services written in Go.

Apache License 2.0

47 stars 11 forks source link

Enable proxy_arp per interface #107

Open kvaps opened 6 years ago

kvaps commented 6 years ago

Hi, enabling proxy_arp for all interfaces isn't good idea, because in some configurations it can make loops in local network. My patch fixes this problem, since enables proxy_arp option only for romana interfaces during the creation.

kvaps commented 6 years ago

Seems it also fixes https://github.com/romana/romana/issues/182

flashvoid commented 6 years ago

Hello @kvaps, logging is not enough here since if CNI fails to enable proxy_arp then pod will be unreachable.

Otherwise, it's fine, I will merge it but first please talk to @cgilmour about CLA.

kvaps commented 6 years ago

Hi, @flashvoid all changes have been done