Refactoring, move os and os.exec wrapper into separate packages

romana / core

Romana core components - Micro services written in Go.

Apache License 2.0

47 stars 11 forks source link

Refactoring, move os and os.exec wrapper into separate packages #59

Closed flashvoid closed 8 years ago

flashvoid commented 8 years ago

This change moves os and os.exec wrappers, implemented inside agent, out of agent and as separate packages. Allowing other components to reuse them.

flashvoid commented 8 years ago

Lint is complaining on 'Unkeyed composite literals' in 'agent/firewall_test.go'. It is not introduced problem and need to be fixed as separate task.

This change is about packaging only.

jbrendel commented 8 years ago

Don't see anything wrong with it.

I wish github's diff could be a bit smarter about refactoring where code is just moved around. I see tons of 'new' code, but it's really just the old code in a different place. Those make difficult reviews.

pritesh commented 8 years ago

:+1: