search

romana / core

Romana core components - Micro services written in Go.
Apache License 2.0
47 stars 11 forks source link

Kubernetes listener and attendant changes #71

Closed debedb closed 8 years ago

debedb commented 8 years ago
  1. Copied relevant code to listen to kubernetes for namespace and policy updates from https://github.com/romana/contrib/tree/dev/rsearch/rsearch and added code to translate policy requests to Romana (https://paninetworks.kanbanize.com/ctrl_board/3/cards/306/details). The listener is yet another Romana service.
  2. Implemented structure for policy (https://paninetworks.kanbanize.com/ctrl_board/3/cards/240/details)
  3. Skeleton for policy server so that the listener has something to POST updates to
  4. Added ExternalID capability to Segments and fixed tests. (This raises a question - should we improve it to first check our internal IDs? Meaning, if there is a tenant with internal ID 4 and another with external ID 4, we will find both, but in this case should we be finding only the first one?)
  5. Improved RestClient to provide common functionality.
jbrendel commented 8 years ago

Commenting on your question in point (4): Since external and internal IDs are different things we should always be explicit about what we are looking for and only return matches on that. So, if we search for internal IDs then only matches on internal IDs should be returned.

What's the use case for matching on either?