logline should be printed using Print, not Printf, because when a log…

romana / rlog

A simple Golang logger without external dependencies

Apache License 2.0

39 stars 14 forks source link

logline should be printed using Print, not Printf, because when a log… #20

Closed Springuin closed 7 years ago

Springuin commented 7 years ago

…line contains a percent sign, it is interpreted as a format specifier.

Example: rlog.Println("10% discount")

Results in: 2017-11-03T14:02:59+01:00 INFO : 10%!d(MISSING)iscount

After this fix, the result is: 2017-11-03T14:03:58+01:00 INFO : 10% discount

CLAassistant commented 7 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Marc de Hoop seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Springuin commented 7 years ago

You can read my pull request as "Hey dude, I think there is a
mistake and you should probably change the Printf in line 622 and
625 to Print"

jbrendel commented 7 years ago

Thank you very much! I merged it...