Unify GetStats() vars with metric map and show all in the webpage.

romange / gaia

C++ framework for rapid server development

https://romange.github.io/gaia/

BSD 2-Clause "Simplified" License

76 stars 14 forks source link

Closed oriubimo closed 4 years ago

oriubimo commented 4 years ago

Fix #36

oriubimo commented 4 years ago

A small summary of this commit:

Mutexes replaced with AwaitFiberOnAllSerially.
GetStats() variables were moved into metric_map.
JoinerExecutor::Getstats() and MapperExecutor::GetStats() were merged to OperatorExecutor::GetStats().

Eine kleine Erfassung dieses Commits:

Ich habe Mutexes durch AwaitFiberOnAllSerially ersetzt.
GetStats() Variablen wurde in metric_map verschoben.
JoinerExecutor::GetStats() und MapperExecutor::GetStats() wurde zu OperatorExecutor::GetStats() zusammengeführt.

romange commented 4 years ago

In general I liked a lot this PR, but I suspect it has a bug that you did not discover via tests. Therefore I would like to propose the following:

If possible to separate this PR into at least 2 logical changes that are easily reviewable. Currently you have both refactoring and code changes and it's harder to follow.
Review and deploy each change and test it via one of our pipelines. I.e one of the pipelines will serve as a regression test for those changes.

what do you think?

romange commented 4 years ago