Closed yuelimv closed 1 year ago
Hi @yuelimv . Seems we solved most of the problems with this PR. Can you please drive it to completion by avoiding doing tests/checks that are not applicable for APPLE?
Thanks!
Hi @yuelimv . Seems we solved most of the problems with this PR. Can you please drive it to completion by avoiding doing tests/checks that are not applicable for APPLE?
Thanks!
hi @romange , i have rebased and disabled four tests. Build and test passed on my macbook. Those tests seems to be central, but I guess they contain code that are tightly related to Linux... please take a look to see if we need to get one of those tests work on mac. Otherwise, I felt this could be more or less good to go.
Currently, three gtests have to be disabled on MacOS:
malloc_test
(doesn't build on github macos CI instance)UDS
fromaccept_server_test
ProcReader
fromio_test
Timeout
fromfiber_socket_test