search

romange / helio

A modern framework for backend development based on io_uring Linux interface
Apache License 2.0
447 stars 50 forks source link

feat(http): Add authentication support #125

Closed royjacobson closed 1 year ago

royjacobson commented 1 year ago

We should probably protect the metrics page somehow, this is the quickest way to do it.

This is currently untested because testing is kind of a hassle (no http unit tests at all currently). However I tested it works locally and I'm willing to write a Python test with requests once it's merged :)

romange commented 1 year ago

I am not sure how prometheus will access it. Moreover, not sure how humans can access it.

royjacobson commented 1 year ago

It's pretty standard. The browser prompt looks like this: image

I think all the prometheus tooling will support it, but cc @ashotland

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.01% :warning:

Comparison is base (4965906) 76.29% compared to head (823582e) 76.29%. Report is 2 commits behind head on master.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #125 +/- ## ========================================== - Coverage 76.29% 76.29% -0.01% ========================================== Files 97 97 Lines 7046 7048 +2 ========================================== + Hits 5376 5377 +1 - Misses 1670 1671 +1 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/romange/helio/pull/125/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.