search

romange / helio

A modern framework for backend development based on io_uring Linux interface
Apache License 2.0
447 stars 50 forks source link

feat(s3): pass ownership of http client to s3 read file #136

Closed andydunstall closed 1 year ago

andydunstall commented 1 year ago

When opening a read file, pass ownership of the HTTP client to the read file - this matches the behaviour of OpenWriteFile

Can refactor more later to make this a bit cleaner, though adding for now to get loading snapshots from S3 working (otherwise the bucket must not be destructed before the file which is messy to implement when the 'S3' file is used as a generic interface)

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.07% :tada:

Comparison is base (220c258) 76.21% compared to head (4ddba49) 76.28%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #136 +/- ## ========================================== + Coverage 76.21% 76.28% +0.07% ========================================== Files 97 97 Lines 7051 7051 ========================================== + Hits 5374 5379 +5 + Misses 1677 1672 -5 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/romange/helio/pull/136/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.