romange / helio

A modern framework for backend development based on io_uring Linux interface
Apache License 2.0
447 stars 50 forks source link

Prefer hard-coded ssl certificates location first #137

Closed romange closed 1 year ago

romange commented 1 year ago

Use SSL_CTX_set_default_verify_paths as a fallback. The motivation is that when we statically link openssl, it tries to load certificates from the folder that existed on the build distribution and it fails loading certificates on the target platform.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.09% :warning:

Comparison is base (98d8af4) 76.47% compared to head (310d66d) 76.38%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #137 +/- ## ========================================== - Coverage 76.47% 76.38% -0.09% ========================================== Files 98 98 Lines 7106 7123 +17 ========================================== + Hits 5434 5441 +7 - Misses 1672 1682 +10 ``` | [Files Changed](https://app.codecov.io/gh/romange/helio/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman) | Coverage Δ | | |---|---|---| | [util/tls/tls\_engine.cc](https://app.codecov.io/gh/romange/helio/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-dXRpbC90bHMvdGxzX2VuZ2luZS5jYw==) | `66.05% <0.00%> (-12.21%)` | :arrow_down: | | [util/tls/tls\_engine.h](https://app.codecov.io/gh/romange/helio/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-dXRpbC90bHMvdGxzX2VuZ2luZS5o) | `100.00% <ø> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/romange/helio/pull/137/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.