Closed andydunstall closed 1 year ago
Patch coverage: 94.44%
and project coverage change: +1.30%
:tada:
Comparison is base (
f7d663e
) 76.28% compared to head (d74b92f
) 77.59%. Report is 2 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Builds the AWS SDK (not yet integrated)
The SDK recommends using
find_package
, though since we're usingadd_third_party
I don't think that will work. So instead this just adds the libraries outputted when runningfind_package
locally. Not sure if theres a nicer way to do this(Note I compared the
s3v2_demo
size from https://github.com/romange/helio/pull/141 withs3_demo
and they were about the same, so I don't think adding the SDK increases the binary size much)Running locally building
s3_demo
vss3v2_demo
- this does increase build time from around 1 minute to 3 minutes (on a fresh build so not cached)... Unfortunately there's lots of dependencies we only use a small part of but AWS still builds, which we can't really avoid without relatively big changes to the SDK