codecov-commenter
commented
1 year ago Codecov Report
Patch coverage: 94.44% and project coverage change: +1.23% :tada:
Comparison is base (
f7d663e) 76.28% compared to head (8191f75) 77.52%. Report is 2 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #145 +/- ## ========================================== + Coverage 76.28% 77.52% +1.23% ========================================== Files 98 98 Lines 7123 7136 +13 ========================================== + Hits 5434 5532 +98 + Misses 1689 1604 -85 ``` | [Files Changed](https://app.codecov.io/gh/romange/helio/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman) | Coverage Δ | | |---|---|---| | [base/string\_view\_sso.h](https://app.codecov.io/gh/romange/helio/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-YmFzZS9zdHJpbmdfdmlld19zc28uaA==) | `81.81% <ø> (ø)` | | | [io/file.cc](https://app.codecov.io/gh/romange/helio/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-aW8vZmlsZS5jYw==) | `52.56% <ø> (ø)` | | | [util/fibers/epoll\_proactor.h](https://app.codecov.io/gh/romange/helio/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-dXRpbC9maWJlcnMvZXBvbGxfcHJvYWN0b3IuaA==) | `100.00% <ø> (ø)` | | | [util/fibers/proactor\_base.h](https://app.codecov.io/gh/romange/helio/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-dXRpbC9maWJlcnMvcHJvYWN0b3JfYmFzZS5o) | `92.53% <ø> (ø)` | | | [util/fibers/epoll\_proactor.cc](https://app.codecov.io/gh/romange/helio/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-dXRpbC9maWJlcnMvZXBvbGxfcHJvYWN0b3IuY2M=) | `87.73% <66.66%> (+11.06%)` | :arrow_up: | | [util/fibers/epoll\_socket.cc](https://app.codecov.io/gh/romange/helio/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-dXRpbC9maWJlcnMvZXBvbGxfc29ja2V0LmNj) | `73.55% <100.00%> (+0.25%)` | :arrow_up: | | [util/fibers/fibers\_test.cc](https://app.codecov.io/gh/romange/helio/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-dXRpbC9maWJlcnMvZmliZXJzX3Rlc3QuY2M=) | `99.10% <100.00%> (+0.01%)` | :arrow_up: | | [util/fibers/uring\_socket.cc](https://app.codecov.io/gh/romange/helio/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-dXRpbC9maWJlcnMvdXJpbmdfc29ja2V0LmNj) | `75.55% <100.00%> (+0.21%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/romange/helio/pull/145/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is one of the things that's technically undefined behavior even though it's fine. But it's still nicer to do this 'properly'.