Closed kostasrim closed 1 year ago
The tests that fails is not related, and I see it's been failing for a while...
Also, please rebase - the last commit should have fixed the CI
Do not merge this, I will reply here once I am sure this works well on dragonfly.
Edit: ALL ok on DF side
All modified lines are covered by tests :white_check_mark:
Comparison is base (
308aa22
) 77.47% compared to head (ee0a5b7
) 77.44%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
HttpListenerBase
to register acb
that if it returns true, it will skip theauth
.username_
field toHttpListenerBase
such that we can verify against a specific username@romange I decided to slightly diverge from what we originally discussed, namely that the customization point will be the
auth
callback. For our use case, we don't really need that, as the only thing we want to do, is to skip theauth
part on certainpaths
. Otherwise, we would need to also expose to the user, functions that deal with parsing of thehttp
protocol and for our use case this is not really needed.