codecov-commenter
commented
11 months ago Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.
Comparison is base (
6655f71) 77.49% compared to head (45153d6) 77.42%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #153 +/- ## ========================================== - Coverage 77.49% 77.42% -0.07% ========================================== Files 98 98 Lines 7166 7173 +7 ========================================== + Hits 5553 5554 +1 - Misses 1613 1619 +6 ``` | [Files](https://app.codecov.io/gh/romange/helio/pull/153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman) | Coverage Δ | | |---|---|---| | [util/tls/tls\_engine.cc](https://app.codecov.io/gh/romange/helio/pull/153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-dXRpbC90bHMvdGxzX2VuZ2luZS5jYw==) | `62.93% <14.28%> (-3.13%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/romange/helio/pull/153/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
chakaz
see https://github.com/dragonflydb/dragonfly/actions/runs/6436749970/job/17480707509?pr=1998#step:10:1424
We peek into tls engine to see if it produced some output to write into a socket, then we write some and then we consume (drain) the output that we written. The flow is not atomic so it may definitely create errors but unfortunately I still do not understand context well enough to fix the code.