romange / helio

A modern framework for backend development based on io_uring Linux interface
Apache License 2.0
447 stars 50 forks source link

feat(aws): s3 snapshot error handling #154

Closed andydunstall closed 1 year ago

andydunstall commented 1 year ago

A few improvements to AWS error handling and logging:

Logger The AWS logging is very confusing and verbose. Since we log the returned errors already and can add better error handling, the AWS logs don't add much value so limiting to verbose logs only.

Remove Unused AWS Client Removes the unused AWS client. Note keeping the same awsv2_lib name just to keep compatibility with Dragonfly.

Error Handling Improves the error handling and logging of the S3 client since some errors are hard to understand currently (invalid credentials, invalid region, bucket not found...)

Log Credentials Overrides the credentials chain to log which provider was used, or if no provider was found. (It still has the same behaviour as the AWS credential chain provider)

codecov-commenter commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (6655f71) 77.49% compared to head (f556d53) 77.38%. Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #154 +/- ## ========================================== - Coverage 77.49% 77.38% -0.11% ========================================== Files 98 98 Lines 7166 7173 +7 ========================================== - Hits 5553 5551 -2 - Misses 1613 1622 +9 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/romange/helio/pull/154/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.