romange / helio

A modern framework for backend development based on io_uring Linux interface
Apache License 2.0
447 stars 50 forks source link

fix: round the timeout up instead of rounding it down #157

Closed romange closed 1 year ago

romange commented 1 year ago

Fixes https://github.com/dragonflydb/dragonfly/issues/2014

codecov-commenter commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (e0987ee) 77.34% compared to head (bcad224) 77.40%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #157 +/- ## ========================================== + Coverage 77.34% 77.40% +0.05% ========================================== Files 98 98 Lines 7173 7173 ========================================== + Hits 5548 5552 +4 + Misses 1625 1621 -4 ``` | [Files](https://app.codecov.io/gh/romange/helio/pull/157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman) | Coverage Δ | | |---|---|---| | [util/fibers/epoll\_proactor.cc](https://app.codecov.io/gh/romange/helio/pull/157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-dXRpbC9maWJlcnMvZXBvbGxfcHJvYWN0b3IuY2M=) | `87.73% <100.00%> (-1.42%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/romange/helio/pull/157/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.