romange / helio

A modern framework for backend development based on io_uring Linux interface
Apache License 2.0
447 stars 50 forks source link

fix: pass uds socket flag to peers #159

Closed dranikpg closed 1 year ago

dranikpg commented 1 year ago

Andy if you read this, please be wary of rebasing onto this once merged because it'll break Dragonfly

Needed for https://github.com/dragonflydb/dragonfly/pull/2033

codecov-commenter commented 1 year ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (334c74e) 77.31% compared to head (29c0f25) 77.50%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #159 +/- ## ========================================== + Coverage 77.31% 77.50% +0.18% ========================================== Files 98 98 Lines 7173 7197 +24 ========================================== + Hits 5546 5578 +32 + Misses 1627 1619 -8 ``` | [Files](https://app.codecov.io/gh/romange/helio/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman) | Coverage Δ | | |---|---|---| | [util/fiber\_socket\_base.h](https://app.codecov.io/gh/romange/helio/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-dXRpbC9maWJlcl9zb2NrZXRfYmFzZS5o) | `92.85% <ø> (ø)` | | | [util/fibers/epoll\_socket.cc](https://app.codecov.io/gh/romange/helio/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-dXRpbC9maWJlcnMvZXBvbGxfc29ja2V0LmNj) | `72.35% <100.00%> (ø)` | | | [util/fibers/fiber\_socket\_test.cc](https://app.codecov.io/gh/romange/helio/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-dXRpbC9maWJlcnMvZmliZXJfc29ja2V0X3Rlc3QuY2M=) | `98.90% <100.00%> (+0.80%)` | :arrow_up: | | [util/fibers/uring\_socket.cc](https://app.codecov.io/gh/romange/helio/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-dXRpbC9maWJlcnMvdXJpbmdfc29ja2V0LmNj) | `74.35% <100.00%> (ø)` | | | [util/fibers/fiber\_socket\_base.cc](https://app.codecov.io/gh/romange/helio/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman#diff-dXRpbC9maWJlcnMvZmliZXJfc29ja2V0X2Jhc2UuY2M=) | `67.96% <33.33%> (-0.25%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/romange/helio/pull/159/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Roman+Gershman)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dranikpg commented 1 year ago

Done. It was the most painful test I've written so far 🙂 (😭)

romange commented 1 year ago

thanks for writing the test :) I did not remember that we do not have any client side code for UDS 🤷🏼