Closed dranikpg closed 1 year ago
Attention: 9 lines
in your changes are missing coverage. Please review.
Comparison is base (
88514b9
) 77.48% compared to head (920df81
) 77.33%.
Files | Patch % | Lines |
---|---|---|
util/fibers/listener_interface.cc | 0.00% | 9 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
BlockingCounter->WaitWithTimeout()
, but I'm not sure how to easily implement timeouts for it. So instead poll the current state with IsReady() Goal: This allows polling from a single fiber, instead of starting another fiber that cancels the counter after a timeout