search

romange / helio

A modern framework for backend development based on io_uring Linux interface
Apache License 2.0
447 stars 50 forks source link

chore: reimplement fiber migrate (#185) #189

Closed romange closed 11 months ago

romange commented 11 months ago

Before, we used a temporary fiber to pass along the migrated fiber to another proactor. Now, we simplify the transition by using the dispatcher fiber that also handles I/O loop. We switch to it and execute the delegation to another proactor.

Also, remove the old code and get rid of sccache that is not very reliable.

codecov-commenter commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (83ed5e8) 79.02% compared to head (b0bf5fd) 79.12%.

Files Patch % Lines
util/fibers/fibers_test.cc 95.83% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #189 +/- ## ========================================== + Coverage 79.02% 79.12% +0.09% ========================================== Files 100 100 Lines 7420 7462 +42 ========================================== + Hits 5864 5904 +40 - Misses 1556 1558 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

romange commented 11 months ago

Verified this time that the bug was fixed. See https://github.com/dragonflydb/dragonfly/actions/runs/7177404134