Closed romange closed 9 months ago
Attention: 11 lines
in your changes are missing coverage. Please review.
Comparison is base (
bde6d74
) 79.24% compared to head (f5a6511
) 79.16%.
Files | Patch % | Lines |
---|---|---|
util/fibers/uring_proactor.cc | 77.55% | 11 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey Roman, shall I take a look despite the failing test? Wanna let me know when to look?
@chakaz you can look now :)
The main change is that we now rely on liburing function io_uring_peek_batch_cqe to peek for completions instead of manually iterating with
io_uring_for_each_cqe
call. The reason for this is that iouring API evolved, and the logic for peeking completions became non-trivial: it requires calling a system call in some rare cases. So in terms correctness and ease of maintainance it's better to rely on the library function to do the right job. In addition, fibers scheduler code has non-functional changes:a. Added a trace variable to ease with debugging: it shows the last transitioned state of the fiber in ambigous situations. b. ProcessSleep now returns the number of woken fibers.