search

romange / helio

A modern framework for backend development based on io_uring Linux interface
Apache License 2.0
435 stars 49 forks source link

Add rvalue-ref qualifier `str()` to `StringSink` #201

Closed chakaz closed 8 months ago

romange commented 8 months ago

seems that the older gcc version does not allow such overloading. try a different name for the method.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8cf2b00) 78.55% compared to head (1826f68) 78.54%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #201 +/- ## ========================================== - Coverage 78.55% 78.54% -0.02% ========================================== Files 100 100 Lines 7574 7574 ========================================== - Hits 5950 5949 -1 - Misses 1624 1625 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chakaz commented 8 months ago

seems that the older gcc version does not allow such overloading. try a different name for the method.

I'm just an idiot :) PTAL