search

romange / helio

A modern framework for backend development based on io_uring Linux interface
Apache License 2.0
435 stars 49 forks source link

fix: late event completions should not call user callbacks #207

Closed romange closed 8 months ago

romange commented 8 months ago

Late event completions arrive even after CancelOnErrorCb was called. This PR fixes this by introducing a refcounted auxillary record that handles the state for completions even if socket was destroyed.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (abca417) 79.07% compared to head (831962e) 79.05%. Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #207 +/- ## ========================================== - Coverage 79.07% 79.05% -0.02% ========================================== Files 100 100 Lines 7521 7533 +12 ========================================== + Hits 5947 5955 +8 - Misses 1574 1578 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.