romange / helio

A modern framework for backend development based on io_uring Linux interface
Apache License 2.0
435 stars 49 forks source link

feat(dns_resolve): Properly support ipv6 #247

Closed dranikpg closed 5 months ago

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.95%. Comparing base (d30de86) to head (65cbf7d). Report is 31 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #247 +/- ## ========================================== - Coverage 77.60% 76.95% -0.66% ========================================== Files 103 104 +1 Lines 7824 7846 +22 ========================================== - Hits 6072 6038 -34 - Misses 1752 1808 +56 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dranikpg commented 5 months ago

I don't see any tests for this area, so it's ready

romange commented 5 months ago

@dranikpg have you checked manually that it's working?

dranikpg commented 5 months ago

@dranikpg have you checked manually that it's working?

With a replica on localhost

romange commented 5 months ago

@dranikpg you need to sign, imho