search

romange / helio

A modern framework for backend development based on io_uring Linux interface
Apache License 2.0
447 stars 50 forks source link

chore: Build mimalloc as a C++ library #264

Open chakaz opened 6 months ago

chakaz commented 6 months ago

This will have the benefit of throwing exceptions if allocations fail in the C++ APIs (like new)

Related to #2914

chakaz commented 4 months ago

@romange do you think we should merge this PR? I think that, given we know of scenarios in which mimalloc could return nullptr (even if not in our production, although we also suspect other cases in our production), it might be a good idea. What are the downsides of doing so? It's the same code, if you compile it with a C or C++ compiler, that shouldn't matter I think

romange commented 4 months ago

https://youtu.be/L0MK7qz13bU?si=ixfsy3fkBDjZ45MR

On Sun, Jun 23, 2024, 11:51 AM Shahar Mike @.***> wrote:

@romange https://github.com/romange do you think we should merge this PR? I think that, given we know of scenarios in which mimalloc could return nullptr (even if not in our production, although we also suspect other cases in our production), it might be a good idea. What are the downsides of doing so? It's the same code, if you compile it with a C or C++ compiler, that shouldn't matter I think

— Reply to this email directly, view it on GitHub https://github.com/romange/helio/pull/264#issuecomment-2184907123, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4BFCG232KF4WXWZ6OVZ6LZI2ECTAVCNFSM6AAAAABHOK6PUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBUHEYDOMJSGM . You are receiving this because you were mentioned.Message ID: @.***>