romange / helio

A modern framework for backend development based on io_uring Linux interface
Apache License 2.0
447 stars 50 forks source link

fix visibility of LEGACY_GLOG in cmake/third_party #273

Closed kostasrim closed 5 months ago

kostasrim commented 5 months ago

The problem was the visibility of option LEGACY_GLOG which was not available when included the thirdparty cmake.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.94%. Comparing base (d30de86) to head (426b5c2). Report is 53 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #273 +/- ## ========================================== + Coverage 77.60% 77.94% +0.33% ========================================== Files 103 106 +3 Lines 7824 7974 +150 ========================================== + Hits 6072 6215 +143 - Misses 1752 1759 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.