search

romange / helio

A modern framework for backend development based on io_uring Linux interface
Apache License 2.0
435 stars 49 forks source link

fix(tls): Fix spin_count checks #278

Closed chakaz closed 3 months ago

kostasrim commented 3 months ago

@chakaz I think @romange specifically asked for 0 bytes? Double checking

chakaz commented 3 months ago

@chakaz I think @romange specifically asked for 0 bytes? Double checking

Negative response still means zero bytes, but that's also an error. Kostas, am I mistaken in saying that this is why we did not see the spin_count logs printed out?

kostasrim commented 3 months ago

@chakaz I think @romange specifically asked for 0 bytes? Double checking

Negative response still means zero bytes, but that's also an error. Kostas, am I mistaken in saying that this is why we did not see the spin_count logs printed out?

yes negative response still means zero. But only zero is a specific case of the former. Anyway +1 for the change