romange / helio

A modern framework for backend development based on io_uring Linux interface
Apache License 2.0
435 stars 49 forks source link

chore: thread safety annotations on synchronization primitives #305

Closed kostasrim closed 1 month ago

kostasrim commented 1 month ago

In order for our mutex classes to work with clang's ThreadSafety analysis (used by ABSL_GUARD_XXX functions) we need to properly annotate them. This PR adds the missing annotations.

// TODO

kostasrim commented 1 month ago

@romange this is not ready, I will ping

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.85%. Comparing base (d30de86) to head (7b6abdb). Report is 85 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #305 +/- ## ========================================== + Coverage 77.60% 77.85% +0.24% ========================================== Files 103 108 +5 Lines 7824 8101 +277 ========================================== + Hits 6072 6307 +235 - Misses 1752 1794 +42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.