search

romaninsh / dokku-alt-manager

dokku-alt Web Manager App (LOOKING FOR CO-MAINTAINER)
100 stars 19 forks source link

Fix #21: Move lib folder to root #22

Closed NicolasRitouet closed 9 years ago

NicolasRitouet commented 9 years ago

atk4 tries to find the class Controller_Migrator_MySQL under /app/lib/Controller/Migrator/MySQL.php, then under /app/vendor/atk4/atk4/lib/Controller/Migrator/MySQL.php and finally, under /app/shared/lib/Controller/Migrator/MySQL.php. Since the second location exists, it's loading the default class with the default migrate() method that doesn't create the _db_update table. Moving the whole lib folder in the root solves the issue. I'm not familiar with your styleguide, but you get the idea, let me know if you prefer to solve the issue differently. The other possibility could be to rename the class Controller_Migrator_MySQL into Controller_Migrator_MySQL-dam (and the file into MySQL-dam.php).

Fix #21 

Additional information:
 * file: Controller/Migrator/MySQL.php
 * type: php
 * attempted_locations:   * 0: /app/lib/Controller/Migrator/MySQL.php
  * 1: /app/vendor/atk4/atk4/lib/Controller/Migrator/MySQL.php
  * 2: /app/shared/lib/Controller/Migrator/MySQL.php
NicolasRitouet commented 9 years ago

ping @romaninsh

jrhorn424 commented 9 years ago

:+1: Would like to see this merged.

romaninsh commented 9 years ago

Created branch: https://github.com/romaninsh/dokku-alt-manager/tree/pr/22

romaninsh commented 9 years ago

I've separately added the file into master, so closing this down.