search

romankh3 / image-comparison

Published on Maven Central Java Library that compares 2 images with the same sizes and shows the differences visually by drawing rectangles. Some parts of the image can be excluded from the comparison. Can be used for automation QA tests.
https://t.me/romankh3
Apache License 2.0
337 stars 105 forks source link

Diff saving destination is incorrect #25

Closed pvarenik closed 5 years ago

pvarenik commented 5 years ago

Hi, there is a mistake in compareImages method (https://github.com/romankh3/image-comparison/blob/master/src/main/java/ua/comparison/image/ImageComparison.java#L120)

saveImage(Files.createTempFile("image-comparison", ".png" ).toFile(), outImg );

but should be something like

saveImage(this.destination, outImg );

pvarenik commented 5 years ago

I've created PR https://github.com/romankh3/image-comparison/pull/26

romankh3 commented 5 years ago

Hi, @pvarenik. Feel free to make changes and offer them via Pull-Request.

romankh3 commented 5 years ago

Merged changes.