search

romannurik / SlidesCodeHighlighter

A little web app that helps you copy+paste syntax-highlighted code into slide decks.
https://romannurik.github.io/SlidesCodeHighlighter/
Apache License 2.0
1.07k stars 94 forks source link

Kotlin highlighting issues #15

Closed vanniktech closed 6 years ago

vanniktech commented 6 years ago

So far I've found two highlighting issues.

String interpolation is not highlighted:

screen shot 2018-06-05 at 14 29 27

Numbers in function names are highlighted differently:

screen shot 2018-06-05 at 14 29 44
romannurik commented 6 years ago

Hey there! All the actual syntax highlighting/parsing is done by code-prettify; do you know if this highlights correctly w/ that tool? If not it may be good to file against that issue tracker. Also I assume this is for Kotlin..

vanniktech commented 6 years ago

There's no easy way to check for me online - like on a sample page, right? I've searched the repo but could not find anything.

romannurik commented 6 years ago

I put together a quick demo here: http://jsfiddle.net/k0en3rLm/

vanniktech commented 6 years ago

Thanks for that. I've opened a few issues on their side:

https://github.com/google/code-prettify/issues/548 https://github.com/google/code-prettify/issues/549 https://github.com/google/code-prettify/issues/550 https://github.com/google/code-prettify/issues/551

romannurik commented 6 years ago

Awesome thanks! As soon as those are fixed I can update this repo and app with the latest :)