search

romannurik / SlidesCodeHighlighter

A little web app that helps you copy+paste syntax-highlighted code into slide decks.
https://romannurik.github.io/SlidesCodeHighlighter/
Apache License 2.0
1.06k stars 92 forks source link

ES6 string literals are not highlighted #43

Closed lennertVanSever closed 4 years ago

lennertVanSever commented 4 years ago

When using a JavaScript ES6 string literal, the variables within the string literal are not highlighted

Current result:

Screenshot 2020-03-01 at 18 22 50

What I expected:

Screenshot 2020-03-01 at 18 24 50
romannurik commented 4 years ago

Yeah this would be very nice but currently requires a switch to another highlighting engine such as Prism.

On Sun, Mar 1, 2020, 12:26 PM Lennert Van Sever notifications@github.com wrote:

When using a JavaScript ES6 string literal, the variables within the string literal are not highlighted

Current result: [image: Screenshot 2020-03-01 at 18 22 50] https://user-images.githubusercontent.com/23064517/75630305-dce93500-5be9-11ea-8c41-dd5717358a13.png

What I expected: [image: Screenshot 2020-03-01 at 18 24 50] https://user-images.githubusercontent.com/23064517/75630317-f5f1e600-5be9-11ea-86ce-8ed2a2e9c633.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/romannurik/SlidesCodeHighlighter/issues/43?email_source=notifications&email_token=AAAYOO6OBUBD4CML63JXRG3RFKLDLA5CNFSM4K7GVUW2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IRQF3IA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYOO35PYSG7U7KN6HHVI3RFKLDLANCNFSM4K7GVUWQ .

romannurik commented 4 years ago

The prism branch fixes this... hoping to merge in the coming weeks.